search

gafusion / omas

Ordered Multidimensional Array Structure
http://gafusion.github.io/omas
MIT License
30 stars 15 forks source link

Omas plot, physics and added rotation to omas_cocos #142

Closed TimSlendebroek closed 3 years ago

TimSlendebroek commented 3 years ago

Looks mostly good. Can you please make sure we run these as part of the regression tests? @orso82 Will do, they were in the regression test but sneakily the sample ods doesnt' have a summary!

codecov[bot] commented 3 years ago

Codecov Report

Merging #142 (ca44970) into master (5b048de) will increase coverage by 0.00%. The diff coverage is 92.15%.

:exclamation: Current head ca44970 differs from pull request most recent head e882084. Consider uploading reports for the commit e882084 to get more accurate results Impacted file tree graph

@@           Coverage Diff           @@
##           master     #142   +/-   ##
=======================================
  Coverage   75.35%   75.35%           
=======================================
  Files          54       54           
  Lines       10810    10823   +13     
=======================================
+ Hits         8146     8156   +10     
- Misses       2664     2667    +3
Impacted Files Coverage Δ
omas/omas_plot.py 79.58% <88.23%> (-0.03%) :arrow_down:
omas/omas_physics.py 71.12% <93.10%> (-0.02%) :arrow_down:
omas/omas_cocos.py 100.00% <100.00%> (ø)
omas/tests/test_omas_physics.py 96.17% <100.00%> (+0.01%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 923a4b8...e882084. Read the comment docs.