Added note to omas_dynamic_machine example for required imports

gafusion / omas

Ordered Multidimensional Array Structure

http://gafusion.github.io/omas

MIT License

30 stars 15 forks source link

Added note to omas_dynamic_machine example for required imports #152

Closed dboeckenhoff closed 3 years ago

dboeckenhoff commented 3 years ago

Solving #149

dboeckenhoff commented 3 years ago

Ci failed in build stage with unit tests. Locally on my machine tests run fine and pass. Not sure what is the problem. Any idea?

orso82 commented 3 years ago

@dboeckenhoff I know that your commit was solicited by @smithsp comment, but I have decided to revert your commit and simply added a note at the beginning of the example that states that to run the MDSplus and omfit_classes are required. I'd really like to keep the examples as focused as possible on the OMAS library itself.

orso82 commented 3 years ago

@dboeckenhoff I don't know why the regression tests are failing now... I am looking into it

orso82 commented 3 years ago

@dboeckenhoff it has to be something in the environment, since an empty commit to a separate branch that was previously ok, also shows a fail: