Closed AreWeDreaming closed 3 years ago
Fixed all the bugs and successfully tested for DIII-D shot 185069.
Stale pull request message
I think this should be ready to merge.
Sorry for my tardiness, just got back from vacation. I committed all of your suggestions. Ready to merge?
I'll take a look at that test failure.
Ok, so I spent too much time on this already. The problem is that it is very hard to debug the failing test due to the exec
statement in line 316
in omas_machine.py
. There is an error somewhere in thomson_scattering_hardware
in d3d.py. However, it seems that I cannot directly import d3d.py
as a module to gain access to the functions in that module.
Should I merge all the commits made to master into this branch? I did this locally on my machine and that did not help.
@AreWeDreaming I'll look into it
@orso82 If you have the time I would not mind looking at it together. Let me know on discord if you are interested.
@AreWeDreaming I finally found time to go over your PR, made some changes, and merged. Thank you for your contribution!
[WIP] Not tested. Requires unit test.