search

gafusion / omas

Ordered Multidimensional Array Structure
http://gafusion.github.io/omas
MIT License
30 stars 15 forks source link

Should parallel quantities have TOR COCOS transform? #159

Closed orso82 closed 3 years ago

orso82 commented 3 years ago

@bclyons12 it occurred to me that the COOCS transformations for the OMAS quantities that are "parallel" to the magnetic field should not have a 'TOR' transformation, since they are uniquely defined by the direction of the magnetic field. These definitions are independent of the definition of the toroidal angle. What do you think?

omas/omas_cocos.py:_cocos_signals['core_profiles.profiles_1d.:.e_field_parallel']='TOR'                                                      # 3.000000 # e_field  parallel  [V.m^-1]
omas/omas_cocos.py:_cocos_signals['core_profiles.profiles_1d.:.ion.:.state.:.velocity.parallel']='TOR'                                       # 2.875000 # velocity  parallel  [m.s^-1]
omas/omas_cocos.py:_cocos_signals['core_profiles.profiles_1d.:.neutral.:.state.:.velocity.parallel']='TOR'                                   # 2.875000 # velocity  parallel  [m.s^-1]
omas/omas_cocos.py:_cocos_signals['core_profiles.profiles_1d.:.ion.:.velocity.parallel']='TOR'                                               # 2.833333 # velocity  parallel  [m.s^-1]
omas/omas_cocos.py:_cocos_signals['core_profiles.profiles_1d.:.neutral.:.velocity.parallel']='TOR'                                           # 2.833333 # velocity  parallel  [m.s^-1]
omas/omas_cocos.py:_cocos_signals['core_profiles.profiles_1d.:.electrons.velocity.parallel']='TOR'                                           # 2.800000 # velocity  parallel  [m.s^-1]
omas/omas_cocos.py:_cocos_signals['core_profiles.profiles_1d.:.e_field.parallel']='TOR'                                                      # 2.750000 # e_field  parallel  [V.m^-1]
omas/omas_cocos.py:_cocos_signals['core_profiles.profiles_1d.:.current_parallel_inside']='TOR'                                               # 2.000000 # current  [A]
omas/omas_cocos.py:_cocos_signals['core_sources.source.:.global_quantities.:.current_parallel']='TOR'                                         # 3.000000 # current  parallel  [A]
omas/omas_cocos.py:_cocos_signals['core_sources.source.:.profiles_1d.:.j_parallel']='TOR'                                                     # 3.000000 # j  parallel  [A.m^-2]
omas/omas_cocos.py:_cocos_signals['core_sources.source.:.profiles_1d.:.current_parallel_inside']='TOR'                                        # 2.000000 # current  [A]
omas/omas_cocos.py:_cocos_signals['equilibrium.time_slice.:.profiles_1d.j_parallel']='TOR'                                                         # 3.000000 # j  parallel  [A/m^2]
omas/omas_cocos.py:_cocos_signals['equilibrium.time_slice.:.profiles_2d.:.j_parallel']='TOR'                                                       # 3.000000 # j  parallel  [A.m^-2]
omas/omas_cocos.py:_cocos_signals['equilibrium.time_slice.:.ggd.:.j_parallel.:.values']='TOR'                                                      # 2.428571 # j  parallel  [A.m^-2]
bclyons12 commented 3 years ago

@orso82 I think you're correct, these should not transform with COCOS changes.