search

gafusion / omas

Ordered Multidimensional Array Structure
http://gafusion.github.io/omas
MIT License
30 stars 14 forks source link

Added d3d machine mappings for ECH #169

Closed AreWeDreaming closed 2 years ago

AreWeDreaming commented 2 years ago

Beam spot size and curvature radius still WIP. Added test and test data. Will convert out of draft mode once I hear beak from ECH group about beam spot size and curvature,

AreWeDreaming commented 2 years ago

I updated the beam spot size and curvature radius after a discussion with Neal Crocker. The beam is focused onto the last mirror which is also the launching point. Hence, the inverse curvature radius is zero.

orso82 commented 2 years ago

I am very glad that you got to talk to Neal I see regression tests failing, which is not surprising since the GH runners do not have MDS+ installed nor access to DIII-D. I suggest you move the test that you have created to an example, or simply remove it all-together.

AreWeDreaming commented 2 years ago

8cc8bfdc0564b1c2afb938a18163399aa46fd918 Removed my beautiful test ;'-(

AreWeDreaming commented 2 years ago

Should be ready to merge now.

orso82 commented 2 years ago

Well done @AreWeDreaming !