search

gafusion / omas

Ordered Multidimensional Array Structure
http://gafusion.github.io/omas
MIT License
32 stars 15 forks source link

IMAS 3.34.0 breaks gas_injection IDS #173

Closed orso82 closed 2 years ago

orso82 commented 2 years ago

@eldond IMAS just released version 3.34.0 of the data dictionary. The new release changes how gas_injection IDS is structured, specifically, it looks like valve is not under pipe anymore.

See the new arrangement: image

You can do make test_no_munittest in the top-level omas directory to see the failing test

eldond commented 2 years ago

Oh dear. I suppose I have to test for IMAS schema version and do two versions of things that look this stuff up, right?

orso82 commented 2 years ago

That's a possibility, but if it was me, I would simply drop support for the older versions

orso82 commented 2 years ago

@eldond I need to release a new version of OMAS soon, definitely by the end of this week, so I have made the minimal fix to make the gas_injection regression work. Still, it would be great if you could bring both the sample as well as the plotting routines up to speed with the new IDS organization.

eldond commented 2 years ago

@orso82 I'm starting on it.