search

gafusion / omas

Ordered Multidimensional Array Structure
http://gafusion.github.io/omas
MIT License
30 stars 14 forks source link

test branch for Joey to work on k-files generation for NSTX #197

Closed jmcclena closed 2 years ago

jmcclena commented 2 years ago

@orso82 This is a branch for testing a fix for fixing issue https://github.com/gafusion/OMFIT-source/issues/6061 by adding in dummy values if mds+ can't be connected to. As validity doesn't exist for pf_active signals, what do you think is the best way to implement some pass if certain coils can't be retrieved from mds+.

orso82 commented 2 years ago

@jmcclena do you understand why certain coils can't be retrieved from MDS+? To me this sounds like we are ousing the wrong mhdin.dat... in other words, if there are only 15 coils in MDS+, then we should be looking for 15, not 18 like we are doing now.

orso82 commented 2 years ago

@jmcclena do you understand why certain coils can't be retrieved from MDS+? To me this sounds like we are ousing the wrong mhdin.dat... in other words, if there are only 15 coils in MDS+, then we should be looking for 15, not 18 like we are doing now.

jmcclena commented 2 years ago

Hmmm... if looks like the signals do not exist below discharge:133139

orso82 commented 2 years ago

I don't think the issue is with the data fetching code itself. The question is: why are we looking for 18 signals when there are only 15 available? are we using the right signals.dat/mhdin.dat files?

smithsp commented 2 years ago

@jmcclena doesn't like this approach.

smithsp commented 2 years ago

Superceded by work in #193