search

gafusion / omas

Ordered Multidimensional Array Structure
http://gafusion.github.io/omas
MIT License
30 stars 14 forks source link

Add currents to omas summary #205

Closed jmcclena closed 1 year ago

jmcclena commented 1 year ago

@TimSlendebroek in doing this, I change some of the behavior some of the other summary routines to avoid modifying original ods with the summary routines. Could you verify that I didn't break anything? I checked that the STEP regression still passes.

TimSlendebroek commented 1 year ago

I tried running this @jmcclena 

OMFIT['ods']= ods= ODS().sample()

ods.physics_core_profiles_consistent()
del ods['summary.global_quantities']
ods.physics_summary_currents()

But the global_quantities currents aren't there :(

github-actions[bot] commented 1 year ago

Stale pull request message

github-actions[bot] commented 1 year ago

Stale pull request message

jmcclena commented 1 year ago

This bot is brutal. I made a commit last week.

orso82 commented 1 year ago

I think the bot only looks for the no-pr-activity label, independently of whether there has been activity or not...

jmcclena commented 1 year ago

@TimSlendebroek Anything else we should change with this pull request?

TimSlendebroek commented 1 year ago

Let's push it :)