search

gafusion / omas

Ordered Multidimensional Array Structure
http://gafusion.github.io/omas
MIT License
30 stars 14 forks source link

Apply COCOs transforms to the ..._error_upper quantities #251

Closed torrinba closed 1 year ago

torrinba commented 1 year ago

Thanks to Orso for suggesting the generic way to handle this!

orso82 commented 1 year ago

Great contribution @bechtt and good thinking @smithsp ! If you are happy with this I think we can merge.

smithsp commented 1 year ago

@bechtt How did you test this? Maybe good to add a test to the test suite. But I am also OK to just merge.

torrinba commented 1 year ago

@bechtt How did you test this? Maybe good to add a test to the test suite. But I am also OK to just merge.

I used OMFIT to convert eqdsk files (specifically the flux loops have a COCOs transformation and uncertainty). That doesn't seem like the best candidate for an omas test unfortunately. I also did not test the ...error_lower conversion or the impact of a sign flip in the COCOs.

orso82 commented 1 year ago

@bechtt if you feel inspired, you can add a regression here: https://github.com/gafusion/omas/blob/master/omas/tests/test_omas_core.py#L103-L107