Closed hassec closed 1 month ago
We're certainly very open!!! Thank you @hassec for taking a deep dive into the setup files of OMAS!!
Perhaps @kalling can comment here. I have not kept up to date with the latest and greatest ways to setup a Python package.
Stale pull request message
I was motivated to fix #289, but when starting to work on the old
setup.py
I was curious if you would be open to a bit of a modernisation, see below:Changes in this PR:
pyproject.toml
following the adopted python standards.setup.py
that translatesomas_cython.pyx
toomas_cython.c
at the time the sdist package is created. This has the benefit thatCython
is no longer a dependency for users. They*.c
file still gets compiled during package install on the users computer, but that still is pretty quick and doesn't produce any warnings.This PR also removes the need to manually traverse the file hierarchy to create
packages
andpackage_data
lists. This is now automatically handled.Editable installs still work by simply running:
To build a sdist package using
build
run:from the root of the project. This creates an isolated virtual environment to build the sdist according to the spec in
pyproject.toml
.