search

gafusion / omas

Ordered Multidimensional Array Structure
http://gafusion.github.io/omas
MIT License
30 stars 14 forks source link

feat(ci): Run tests for more python versions #296

Closed hassec closed 3 months ago

hassec commented 4 months ago

I wanted to disentangle the fixing of builds for specific python versions from #293.

So this PR keeps the setup.py way of building OMAS and does not yet fix anything in regard to the Cython warnings.

All that this PR does is update the CI to also run the tests for python versions 3.6-3.11, and apply some small fixes or workarounds to make the OMAS tests pass for these python versions.

We only use OMAS with python >=3.10 so would love to see these tests as part of the CI to ensure everything works as expected on these versions too.

orso82 commented 4 months ago

Thank you @hassec !! Fantastic! @smithsp @kalling can you please take a look as well? Then I think we can merge!

hassec commented 4 months ago

@smithsp was that comment for me? What would you like to see checked aside from what's shown in the CI?

kalling commented 4 months ago

I verified the tests work locally with those OMFIT changes. Testing here would probably need a new omfit_classes release as @hassec mentioned as a comment in my review.

smithsp commented 4 months ago

@hassec regarding https://github.com/gafusion/omas/pull/296#issuecomment-1979436546 , yes, I am just asking that you double check the CI outputs to be sure the 3.7 tests run the same tests as the other versions.

hassec commented 4 months ago

@smithsp yes, on all versions we collect 141 tests. 3.6 skips 13 3.7 skips 14 ( this is the omfit_classes bug we will wait for and as soon as that is on pypi we can remove the skipping of that additional test) For python >= 3.8 it skips 15 tests. This is higher due to omfit + xarray problem.