refactor(test) remove workaround for old omfit_classes version

gafusion / omas

Ordered Multidimensional Array Structure

http://gafusion.github.io/omas

MIT License

30 stars 14 forks source link

refactor(test) remove workaround for old omfit_classes version #297

Closed hassec closed 1 month ago

hassec commented 3 months ago

@kalling As promised, removing the workaround now that omfit_classes is updated

hassec commented 3 months ago

Interesting, it installed omfit_classes==3.2024.9.2 but failed. Will investigate

kalling commented 3 months ago

@hassec It looks like the new master wasn't created yet. I am guessing some (OMFIT) tests failed, but will take a look. (The new package has the previous master, just much newer one than the last package posted to pypi)

kalling commented 3 months ago

(I am basically saying the fixed code isn't in the pypi package yet)

hassec commented 3 months ago

@kalling Where would I be able to see/check if a new omfit_classes is deployed or if a potential error was encountered? (to avoid bugging you here 😅)

kalling commented 3 months ago

omfit_classes got updated on pypi yesterday due to the new master release, so theoretically the fix should be in.

hassec commented 3 months ago

@kalling yep just reran the tests and they now all pass 🎉

github-actions[bot] commented 1 month ago

Stale pull request message