search

gafusion / omas

Ordered Multidimensional Array Structure
http://gafusion.github.io/omas
MIT License
30 stars 14 forks source link

Fixes to get machine mappings working for other experiments again #304

Closed torrinba closed 3 months ago

torrinba commented 3 months ago

Source all compatible machines, protect against any that aren't, add missing dependencies, and include missing checks

orso82 commented 3 months ago

this all looks reasonable to me!

I suspect the breaking changes were introduced by some (much needed) refactoring thst @AreWeDreaming did?

If so, @AreWeDreaming can you please double check this PR?

AreWeDreaming commented 3 months ago

I also see nothing wrong with this inherently. Do we have any known users of the machine mappings for NSTX that we can ask them to test this PR in whatever they use OMAS for?

torrinba commented 3 months ago

The generation of k-files (which is tested in OMFIT and how I found these problems) is the only one actively used that I'm aware of.

I messaged @jmcclena about testing that for other machines (not in the OMFIT regressions) like MAST. He might have more use cases as well

torrinba commented 3 months ago

Since this branch is already being used in OMFIT (because of the issues that had to be fixed). I am in favor of merging it before OMFIT breaks from an automatic OMAS update. We should certainly continue testing and looking for any outstanding issues though