gafusion / omas

Ordered Multidimensional Array Structure
http://gafusion.github.io/omas
MIT License
30 stars 14 forks source link

ECH polarization is incorrect for newer shots #310

Open AreWeDreaming opened 6 days ago

AreWeDreaming commented 6 days ago

For example 189588 triggers: https://github.com/gafusion/omas/blob/65e8238283eb0e985a94dc86c0512b41e2cdc679/omas/machine_mappings/d3d.py#L578 The default return value of 0 is not great because it should either be -1 or 1. See https://sharepoint.iter.org/departments/POP/CM/IMDesign/Data%20Model/CI/imas-3.41.0/ec_launchers.html

AreWeDreaming commented 6 days ago

Upon closer inspection it seems that this error only occurs if the shot did not have power.