search

gafusion / omas

Ordered Multidimensional Array Structure
http://gafusion.github.io/omas
MIT License
32 stars 15 forks source link

Make tests/__init__.py robust to python 2 vs 3 #44

Closed smithsp closed 6 years ago

codecov[bot] commented 6 years ago

Codecov Report

Merging #44 into master will decrease coverage by 0.36%. The diff coverage is 58.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #44      +/-   ##
==========================================
- Coverage   70.51%   70.14%   -0.37%     
==========================================
  Files          21       21              
  Lines        4328     4335       +7     
==========================================
- Hits         3052     3041      -11     
- Misses       1276     1294      +18
Impacted Files Coverage Δ
omas/tests/__init__.py 58.33% <58.33%> (-41.67%) :arrow_down:
omas/omas_setup.py 57.37% <0%> (-21.32%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update c2dfc74...0fdd084. Read the comment docs.

orso82 commented 6 years ago

@smithsp should I close this PR?

smithsp commented 6 years ago

This didn't pass regressions, and so missed the point of helping pass regressions.