gafusion / omas

Ordered Multidimensional Array Structure
http://gafusion.github.io/omas
MIT License
32 stars 15 forks source link

Timing load of IMAS data #61

Closed orso82 closed 3 years ago

orso82 commented 5 years ago

see https://github.com/gafusion/omas/commit/0f7285ac9da71cf8982e427a15e3a95e8c280c83#commitcomment-32969860

orso82 commented 5 years ago

@jsferreira I opened this issue to see what we can do to speedup the loading from IMAS

Could you please share the piece of code that you have used to generate your timings? This way I can test it myself and perhaps find if there are bottlenecks on the OMAS side that I can iron out.

jsferreira commented 5 years ago

@orso82

With omas/0.35.0 the loading times are similar. Still need to test the last commit.

The tests are very simple. At the WPCD gateway with omas/0.35.0:

orso82 commented 5 years ago

Thank you @jsferreira . The speedup that I saw were measured when accessing data that was already within an ODS, for example when using the .from_omas() and .to_omas() in the OMFIT classes. I'll see if there is something that I can do to improve the performance of load_omas_imas()

orso82 commented 5 years ago

@jsferreira I have to remind myself how I used to connect to the gateway server. Latest OMAS version 0.37.0 should do a lot better. Please let me know once you get the chance to test it.

orso82 commented 5 years ago

@jsferreira with commit a3d86707868eaff6a81e815b9311d525f98846ca you should now be able to skip loading of ggd structures. I have not field tested this so please let me know if you find any issues.

jsferreira commented 5 years ago

Another useful thing to have would be a way to import into OMAS only a slice of the IDS, eg. by using the getSlice

github-actions[bot] commented 3 years ago

Stale issue message