Karel-van-de-Plassche commented 5 years ago

self.dynamic_path_creation is a boolean, not a string. Looks like this blob of code is not tested, I'm not sure when it's supposed to trigger, so please add a test.

codecov[bot] commented 5 years ago

Codecov Report

Merging #72 into master will not change coverage. The diff coverage is 100%.

@@           Coverage Diff           @@
##           master      #72   +/-   ##
=======================================
  Coverage   76.76%   76.76%           
=======================================
  Files          23       23           
  Lines        5616     5616           
=======================================
  Hits         4311     4311           
  Misses       1305     1305

Impacted Files	Coverage Δ
omas/omas_core.py	`82.9% <100%> (ø)`	:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 76ce449...d274e4e. Read the comment docs.

orso82 commented 5 years ago

addressed with 13cf16003281e09b00ac6df30b6baaca6c0b54a6

gafusion / omas

Bugfix/dynamic path creation #72

Codecov Report