Karel-van-de-Plassche commented 5 years ago

Seeing from the lines above, this would be expected behaviour. Now it triggers also when setting 'regular' deep arrays indices. If this is not expected, please add a test that tests the contrary. Fixed typo in index check error.

codecov[bot] commented 5 years ago

Codecov Report

Merging #73 into master will increase coverage by 0.1%. The diff coverage is 95.45%.

@@            Coverage Diff            @@
##           master      #73     +/-   ##
=========================================
+ Coverage   76.76%   76.86%   +0.1%     
=========================================
  Files          23       23             
  Lines        5616     5632     +16     
=========================================
+ Hits         4311     4329     +18     
+ Misses       1305     1303      -2

Impacted Files	Coverage Δ
omas/tests/test_omas_core.py	`95.56% <100%> (+0.27%)`	:arrow_up:
omas/omas_core.py	`83.24% <90%> (+0.34%)`	:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 76ce449...7e299cc. Read the comment docs.

orso82 commented 5 years ago

Thank you @Karel-van-de-Plassche 👍 I ended up somewhat refactoring that part to avoid code repetition and improve readability/logic.

Karel-van-de-Plassche commented 5 years ago

Great, looks good!

gafusion / omas

Added setting deeper array index #73

Codecov Report