gafusion / omas

Ordered Multidimensional Array Structure
http://gafusion.github.io/omas
MIT License
32 stars 15 forks source link

Added stored energy calculation in equilibrium ods called in equilibrium_consistent() #83

Closed TimSlendebroek closed 4 years ago

codecov[bot] commented 4 years ago

Codecov Report

Merging #83 into master will increase coverage by 0.29%. The diff coverage is 89.47%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #83      +/-   ##
==========================================
+ Coverage   76.84%   77.13%   +0.29%     
==========================================
  Files          24       24              
  Lines        6538     6557      +19     
==========================================
+ Hits         5024     5058      +34     
+ Misses       1514     1499      -15
Impacted Files Coverage Δ
omas/tests/test_omas_physics.py 95.39% <100%> (+0.08%) :arrow_up:
omas/omas_physics.py 80.6% <84.61%> (+2.7%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 5ea4329...ae26cb1. Read the comment docs.

orso82 commented 4 years ago

Great! Thank you @TimSlendebroek

Could you please add it to the regression tests under test_omas_physics https://github.com/gafusion/omas/blob/TSdev_branch/omas/tests/test_omas_physics.py

orso82 commented 4 years ago

@TimSlendebroek you are right that equilibrium_consistent() would test your script, but (my mistake) we do not test that. In fact, if you could add a test_equilibrium_consistent() routine that would be great!

TimSlendebroek commented 4 years ago

Sure thing, I will look around the rest of the tests what the format is. I guess this will show up in the automatic codecov that is being done on the codebase?

orso82 commented 4 years ago

Yes. It should show up on the codedov and hopefully not as a failed test on the TravisCI regressions :) NOTE: You can run make tests in the top level omas folder to run the same regressions that TravisCI would run.

TimSlendebroek commented 4 years ago

added reg test!

orso82 commented 4 years ago

It looks like you also found a bug in doing so ;) 👍