Closed TimSlendebroek closed 4 years ago
Great! Thank you @TimSlendebroek
Could you please add it to the regression tests under test_omas_physics
https://github.com/gafusion/omas/blob/TSdev_branch/omas/tests/test_omas_physics.py
@TimSlendebroek you are right that equilibrium_consistent()
would test your script, but (my mistake) we do not test that. In fact, if you could add a test_equilibrium_consistent()
routine that would be great!
Sure thing, I will look around the rest of the tests what the format is. I guess this will show up in the automatic codecov that is being done on the codebase?
Yes. It should show up on the codedov and hopefully not as a failed test on the TravisCI regressions :) NOTE: You can run make tests
in the top level omas
folder to run the same regressions that TravisCI would run.
added reg test!
It looks like you also found a bug in doing so ;) 👍
Codecov Report
95.39% <100%> (+0.08%)
80.6% <84.61%> (+2.7%)
Continue to review full report at Codecov.