search

gafusion / omas

Ordered Multidimensional Array Structure
http://gafusion.github.io/omas
MIT License
32 stars 15 forks source link

Fix missing 'data_type' in consistency_checker #95

Closed bclyons12 closed 4 years ago

bclyons12 commented 4 years ago

This was causing an error when trying to enter a location in OMFIT using consistency_check='warn'

eldond commented 4 years ago

@bclyons12 Your build is failing because of the numpy version that travis is using. The requirements file doesn't specify a version, but if you specify one, it can pass. I fixed this in #96.

codecov[bot] commented 4 years ago

Codecov Report

Merging #95 into master will not change coverage by %. The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #95   +/-   ##
=======================================
  Coverage   79.85%   79.85%           
=======================================
  Files          45       45           
  Lines        7869     7869           
=======================================
  Hits         6284     6284           
  Misses       1585     1585
Impacted Files Coverage Δ
omas/omas_core.py 86.13% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update d385cc7...2a29b34. Read the comment docs.

bclyons12 commented 4 years ago

@eldond I don't understand. I hadn't changed any files or requirements besides editing one line.

eldond commented 4 years ago

@bclyons12 As part of the test process, travis sets up a fresh virtual machine from a template and does pip install . to install the repo. If new versions of packages come out, the installed version can change, unless the requirement file specifies specific versions. The OMAS requirements were not specific to any numpy version, so our build was vulnerable to changes in our dependencies.