search

gagan3012 / streamlit-tags

Custom Tag component for streamlit
https://streamlit-tags.readthedocs.io/en/latest/
MIT License
281 stars 17 forks source link

The widget returns the string but not list in the streamlit v0.83 above. #30

Closed tonylegend closed 3 years ago

tonylegend commented 3 years ago

Describe the bug The widget returns the string but not list in the streamlit v0.83 above.

To Reproduce Steps to reproduce the behavior: Just upgrade the streamlit to 0.83 above and using the example code in the repo can reproduce this issue.

Expected behavior Return a list of strings like ['one', 'two', 'three']

Expected behavior Return a string representation like "['one', 'two', 'three']".

Desktop (please complete the following information):

GitHunter0 commented 3 years ago

@gagan3012 , same here, I will try to downgrade it

gagan3012 commented 3 years ago

Hello,

I was testing this with 

streamlit==0.85.1
streamlit_tags==1.2.8

using the code 

keywords = st_tags(
    label='# Enter Keywords:',
    text='Press enter to add more',
    value=['Zero', 'One', 'Two'],
    suggestions=['five', 'six', 'seven', 'eight', 'nine', 'three', 'eleven', 'ten', 'four'],
    maxtags=maxtags,
    key="aljnf")

st.write("### Type:")
st.write(type(keywords))

Output: <class 'list'>

This is the expected behavior from st_tags can you share your code too?

GitHunter0 commented 3 years ago

@gagan3012 , I was testing with streamlit 0.84.0, the issue was solved after I updated to streamlit 0.85.1, thanks for the feedback!

tonylegend commented 3 years ago

Hello,

I was testing this with

streamlit==0.85.1
streamlit_tags==1.2.8

using the code

keywords = st_tags(
    label='# Enter Keywords:',
    text='Press enter to add more',
    value=['Zero', 'One', 'Two'],
    suggestions=['five', 'six', 'seven', 'eight', 'nine', 'three', 'eleven', 'ten', 'four'],
    maxtags=maxtags,
    key="aljnf")

st.write("### Type:")
st.write(type(keywords))

Output: <class 'list'>

This is the expected behavior from st_tags can you share your code too?

I did not try on 0.85 due to the dataframe dtype issue after pyarrow migration. Currently I can manually convert the results on 0.84. Thanks for your information anyway.