search

gagandeepb / Frames-beam

Accessing Postgres in a data frame in Haskell
BSD 3-Clause "New" or "Revised" License
24 stars 3 forks source link

update to lts-14.1 #21

Open jimenezjorge opened 5 years ago

jimenezjorge commented 5 years ago

Hi Gagandeep! I was looking at your work, good stuff! In order to study/experiment with it I was able to update it to lts-14.1; would you be interested if I submitted the changes I have as a PR? Might help other learners like me who want to look at it. Best, Jorge

gagandeepb commented 5 years ago

Hi Jorge, This would be pretty useful! Sure, please go ahead and submit a PR. Cheers.

On Mon, 19 Aug 2019 at 6:03 AM, jimenezjorge notifications@github.com wrote:

Hi Gagandeep! I was looking at your work, good stuff! In order to study/experiment with it I was able to update it to lts-14.1; would you be interested if I submitted the changes I have as a PR? Might help other learners like me who want to look at it. Best, Jorge

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/gagandeepb/Frames-beam/issues/21?email_source=notifications&email_token=AEKMPJT6R3RNEGEMSBKCTWDQFILPVA5CNFSM4IMWFAEKYY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4HF4FQGA, or mute the thread https://github.com/notifications/unsubscribe-auth/AEKMPJRDCOJTLXZLXUH4LF3QFILPVANCNFSM4IMWFAEA .

jimenezjorge commented 5 years ago

Hi Gagandeep, I spoke too soon. Sorry about that. I closed the PR I submitted. The library builds with stack, but stack test does not pass, because are some issues in the current version of Beam that I cannot fix. It is an error in the schema that Beam generates. I submitted this issue to the Beam repo: https://github.com/tathougies/beam/issues/395 . I'll monitor it and when it is fixed I'll submit a PR again. If you want to look at the modifications I made you can look at https://github.com/jimenezjorge/Frames-beam/tree/update-to-lts-14.1 Best, Jorge

gagandeepb commented 5 years ago

No worries, Jorge. Thanks for looking into this, and documenting the things required to update to lts-14.1, as well as filing the issue upstream, with beam. Look forward to your PR once the upstream issue is fixed.