Open dlstadther opened 1 year ago
Honestly, I just started out following the same folder structure as pandas: ls venv/lib/python3.10/site-packages/pandas/tests
https://docs.python-guide.org/writing/structure/ favors your test location though. I'm in favor of moving it out of the package.
pytest docs also favor tests located outside of the package: https://docs.pytest.org/en/latest/explanation/goodpractices.html
Addressing here: https://github.com/gage-russell/pandas-lineage/pull/33
Taking a couple steps further though -- going ahead and redoing CI step to use poetry and expanding test matrix. Currently getting a memory error (exit code 134) on one step. Will reduce the change to just be movement of test directory and create separate issue for better usage of poetry in CI if I continue running into issues.
Currently (0.0.2), the
tests
directory is being included in the installation of this package.Steps to repeat:
Suggestion: Move
tests
directory outside of package location and update CI and pyproject.toml.Typically, i see
tests
directories at the same file path hierarchy as the pkg itself. e.g.