gagoar / use-herald-action

GitHub action to add reviewers, subscribers, labels, and assignees to your PR. You can validate your PR template as well.
https://gagoar.github.io/use-herald-action/
MIT License
54 stars 6 forks source link

Execute status rule if every rule fails #531

Closed andrecrts closed 2 years ago

andrecrts commented 2 years ago

Issue Reference:#530

Description

i updated the getMatchingRules method to return all the status rules and also the validation to update the status to be success or failure depending on the match result and not if it exists on the Matching rules

Motivation and Context

it fixes this Issue 530

How Has This Been Tested?

i've tested it on my private repo where i have just one status rule

Checklist:

codecov[bot] commented 2 years ago

Codecov Report

Base: 100.00% // Head: 100.00% // No change to project coverage :thumbsup:

Coverage data is based on head (16daa31) compared to base (832e036). Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #531 +/- ## ========================================= Coverage 100.00% 100.00% ========================================= Files 8 8 Lines 344 346 +2 Branches 54 54 ========================================= + Hits 344 346 +2 ``` | Flag | Coverage Δ | | |---|---|---| | unittests | `100.00% <100.00%> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Gago#carryforward-flags-in-the-pull-request-comment) to find out more. | [Impacted Files](https://codecov.io/gh/gagoar/use-herald-action/pull/531?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Gago) | Coverage Δ | | |---|---|---| | [src/index.ts](https://codecov.io/gh/gagoar/use-herald-action/pull/531/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Gago#diff-c3JjL2luZGV4LnRz) | `100.00% <ø> (ø)` | | | [src/rules.ts](https://codecov.io/gh/gagoar/use-herald-action/pull/531/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Gago#diff-c3JjL3J1bGVzLnRz) | `100.00% <100.00%> (ø)` | | | [src/statuses.ts](https://codecov.io/gh/gagoar/use-herald-action/pull/531/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Gago#diff-c3JjL3N0YXR1c2VzLnRz) | `100.00% <100.00%> (ø)` | | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Gago). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Gago)

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

sonarcloud[bot] commented 2 years ago

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

gagoar commented 2 years ago

Thanks @andrecrts I will release shortly