fix excludes and log a little more

gagoar / use-herald-action

GitHub action to add reviewers, subscribers, labels, and assignees to your PR. You can validate your PR template as well.

https://gagoar.github.io/use-herald-action/

MIT License

53 stars 7 forks source link

Open scamden opened 2 months ago

scamden commented 2 months ago

This PR fixes a bug we find when using includes and excludes clauses within the same rule.
closes https://github.com/gagoar/use-herald-action/issues/541

sonarcloud[bot] commented 2 months ago

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

gagoar commented 1 month ago

It looks good! It is missing a test that includes the rule I asked you in the issue. Could you share it, so I make sure we don't regress ? thank you!

scamden commented 1 month ago

It looks good! It is missing a test that includes the rule I asked you in the issue. Could you share it, so I make sure we don't regress ? thank you!

Sorry pretty busy with the day job! It's any rule that includes a directory with */ and then exludes some sub folder

{ "includes" : "someFolder/*/", "excludes" : "someFolder/subFolder/*" // other options }