search

gaia-pipeline / gaia

Build powerful pipelines in any programming language.
Apache License 2.0
5.2k stars 245 forks source link

Echo groups (fix #252) #253

Closed speza closed 4 years ago

speza commented 4 years ago

So this utilises echo groups to manage what endpoints have the auth middleware applied. This is nice a clean and lets us avoid using the nonProtectedPathsPrefix and nonProtectedPaths slices on every request.

Fixes #252.

Skarlso commented 4 years ago

@speza Did you have a chance to test this with a production build of Gaia as well making sure all elements like favico and such are displayed correctly?

speza commented 4 years ago

@speza Did you have a chance to test this with a production build of Gaia as well making sure all elements like favico and such are displayed correctly?

@Skarlso what is the best way to build a production version? Build the Dockerfile?

Skarlso commented 4 years ago

@speza I actually started testing this for you. :) I wanted to make sure the build process still works anyways. Don't worry about it. :)

Skarlso commented 4 years ago

Tested this with a release. Seems to work fine. :) I used the Helm charts and a kubernetes release.