Delete user rbac attachments on deletion of users

gaia-pipeline / gaia

Build powerful pipelines in any programming language.

Apache License 2.0

5.2k stars 245 forks source link

Delete user rbac attachments on deletion of users #271

Closed speza closed 4 years ago

speza commented 4 years ago

Add a DeleteUser method so we can delete rbac attachments for a user.
Make noop.go fully no-op (makes sure that a call to DeleteUser) even with RBAC off is OK. All other endpoints now fully no-op for consistency.
Introduce a UserHandler to contain dependencies for the user handlers

speza commented 4 years ago

This looks fine but please extract the user handler creation into server.go so init handler remains testable. InitHandler just used the user handler and shouldn't create it. It should be injected like the rest of the handlers.

@Skarlso do you want me to make a UserProivder? and I did the same with RBACHandler, so could make an RBACProvider?

Skarlso commented 4 years ago

LGTM will merge after testing on the test instance.

Skarlso commented 4 years ago

Will merge soon