search

gaia-platform / rosbag2_snapshot

A ROS2 port of rosbag_snapshot
18 stars 12 forks source link

Add feature: systemwide memory limit in snapshotter. #10

Closed NorCalRobotics closed 2 years ago

JWhitleyWork commented 2 years ago

@JackAtGaia / @LaurentiuCristofor / @stevegaia Would you guys mind taking a look at this feature addition? The dev says it's "a little hacky" so he wanted a few more eyeballs on it.

LaurentiuCristofor commented 2 years ago

@JackAtGaia / @LaurentiuCristofor / @stevegaia Would you guys mind taking a look at this feature addition? The dev says it's "a little hacky" so he wanted a few more eyeballs on it.

Keep in mind that I'm not very familiar with ROS and this project. Can you describe this feature at a high level? Also, if there are particular areas of code that you want reviewed, can you point them out with comments (PR comments, not code comments)?

vDonGlover commented 2 years ago

Note to reviewers: Please do not merge this PR until we have finalized our agreements for external contributions.