search

gaia-platform / rosbag2_snapshot

A ROS2 port of rosbag_snapshot
18 stars 12 forks source link

Seg fault issues in snapshotter.cpp #13

Open jihyunl2 opened 2 years ago

jihyunl2 commented 2 years ago

I came across some lines in snapshotter.cpp such as 768 or 826 where smart pointers that haven't been allocated a portion of memory yet were causing segmentation fault.

jihyunl2 commented 2 years ago

Line 801: if (future_result == rclcpp::FutureReturnCode::SUCCESS) doesn't seem to make sense to me. Shouldn't it be != instead? If not, could you explain why? Thanks in advance.