gaintpd / cutechess

Cute Chess is a graphical user interface, command-line interface and a library for playing chess. This Repo cantains the xiangqi, minixiangqi and manchu variant support
GNU General Public License v3.0
4 stars 3 forks source link

"Cute Janggi" move notation problem and game save&load error. #4

Closed cjssh1002 closed 4 years ago

cjssh1002 commented 4 years ago

PAWN(P) is missing from Cute janggi's movement record. So I can't load the game normally after saving. Request to unite coordinate notation.

Coordinate notation has been separated. reference pic. So we cannot share PGN files. Is there any workaround for this? 좌표

image This is the coordinates used in Korea.

cjssh1002 commented 4 years ago

Dear. Albert

First of all, thanks for sharing Cutejanggi 1.01. We are testing the program by sharing it with many users. There seems to be no particularly dangerous problem.

I think there are a lot of problems with the Pychess notation. SAN notation is used, but it is not clear. So I recommend the X/Winboard notation. It is similar to Korea notation. If you express the "P" movement, it will be normal game loading, and I can create an openingbook.

cjssh1002 commented 4 years ago

i made isuess. https://github.com/ianfab/Fairy-Stockfish/issues/152

cjssh1002 commented 4 years ago

Hello, gaintpd Happy weekend evening.

All coordinate notation of the current janggi board is indicated by numbers. The horizontal lines are 1 to 0 from top to bottom, and the vertical lines are 1 to 9 from left to right, respectively. When reading the intersection of a horizontal line and a vertical line, the horizontal line is read first, and then the vertical line is read later. For example, the initial coordinate positions of the kings of White(楚) and Black(漢) are 95 and 25, respectively. When writing a notation, to indicate the movement of the object, write the coordinates before the object moved, the name of the object that moved, and the coordinates after the object moved. For example, if "N"(horse) in 03 moves to 84, it is marked as “03馬84”. In Korean, it is 03마84.(In English 03N84)

  1. N = 마(馬)
  2. R = 차(車)
  3. B = 상(象)
  4. P(White) = 졸(卒) P(Black)= 병(兵)
  5. A = 사(士)
  6. C = 포(包)
  7. K = 장(楚, 漢)

There is no problem in using Chinese characters. we can understand.

In chess notation, 1 move = 2 count. In janggi, 1 move = 1 count

Check the coordinates of the same movements of cutechess and janggidosa.

=> 1. b4 h7 {8.2s} 2. Ng3 {4.6s} Nd8 {4.4s} 3. Ce3 {4.3s} Ng8 {13s} 4. f4+ {9.5s} Cbe8 {5.9s} 5. Be4 {5.9s} c6 {1.6s} 6. Bc7 {4.3s} Ra9 {5.4s} 7. Cxb10 {6.8s} d7 {1.7s} *

=> 1. 71졸72 2. 49병48 3. 08마87 4. 13마34 5. 88포85 6. 18마37

  1. 75졸76장군 8. 32포35 9. 07상75 10. 43병53 11. 75상43 12. 11차21
  2. 82포12상 14. 45병44

=>1. 71卒72 2. 49兵48 3. 08馬87 4. 13馬34 5. 88包85 6. 18馬37

  1. 75卒76장군 8. 32包35 9. 07象75 10. 43兵53 11. 75象43 12. 11車21
  2. 82包12象 14. 45兵44

This is Korean standard coordinates. 장기도사20200620-204011

However, I hope it is compatible with winboard coordinates. Because if you create a PGN file from cute chess, it cannot be compatible with the Korea Janggidosa program. This is because the method of displaying the location is different. And PGN is compatible with Winboard program.

Winboard coordinates start at 0 with a vertical line. Everything else is the same as CUTECHESS.

The coordinates used below are English expression coordinates used in Korea. Same as winboard coordinates. 장기도사20200620-210351

Thanks for your help.

gaintpd commented 4 years ago

This issue is settled, now you can load the pgn game into the database with the commit of d5eec04772e42225b119a81ec61f7882cb2240fe

gaintpd commented 4 years ago

This issue is closed now as it has been settled, if you encounter such error again, please feel free to reopen it.