Location of examples and content of algorithms.jl

gaioguys / GAIO.jl

A Julia package for set oriented computations.

MIT License

9 stars 4 forks source link

Location of examples and content of algorithms.jl #11

Closed FrederikSchnack closed 4 years ago

FrederikSchnack commented 4 years ago

Currently, the examples in GAIO.jl/examples and their dependencies get included in the GAIO package. This should be discussed. Possible options are for example:

Moving the examples to their own package.
Keeping them at their place and remove the inclusion.
Moving them to GAIO.jl/src/examples and keep the inclusion.

Furthermore, we wanted to discuss the content of GAIO.jl/src/algorithms.jl, i.e. should we keep functions like the adaptive_newton_step in there?

What are your opinions?

gaioguy commented 4 years ago

👍 for moving them into their own package.

Concerning the content of algorithms.jl: cover_roots certainly should be in there - and so we also need adaptive_newton_step (cf. #12, though). We can remove the dependency from ForwardDiff by requiring the caller to explicitely supply the derivative.

cafaxo commented 4 years ago

Instructions for testing examples in #16.

cafaxo commented 4 years ago

We can close this issue since #16 fixed one part and the other part is discussed in #12.