search

gaioguys / GAIO.jl

A Julia package for set oriented computations.
MIT License
9 stars 4 forks source link

WIP: Add BoxGraph for strongly connected components and transition matrix #20

Closed cafaxo closed 3 years ago

cafaxo commented 4 years ago

Reopen #18 since it was closed by accident. Fixes #6 and #14.

FrederikSchnack commented 4 years ago

For the visualisation of the transition graph of a invariant set, we could consider plotting the boxes with opacity according to their weight in the graph. We can also work on this, after this pull request, i would open a issue then.

gaioguy commented 4 years ago

Hm, not sure whether I understand: In the transition graph, the edges are weighted, not the nodes. And further: What do the weights tell us about the dynamics?

cafaxo commented 4 years ago

As I understood it, @FrederikSchnack wants to visualize a measure computed from the transition matrix.

FrederikSchnack commented 4 years ago

I was referencing the visualisation in the end of section 4 in Dellnitz, M.; Junge, O.: Set oriented numerical methods for dynamical systems, B. Fiedler, G. Iooss and N. Kopell (eds.): Handbook of Dynamical Systems III: Towards Applications, World Scientific, 2002.

gaioguy commented 4 years ago

Sure, yes, this is something we should ultimately be aming for!

cafaxo commented 3 years ago

Superseded by the idea at https://github.com/gaioguys/GAIO.jl/pull/32#issuecomment-663098767.

gaioguy commented 3 years ago

Maybe we should still leave this open. I think the graph is there to stay, maybe in a slightly different form.

cafaxo commented 3 years ago

A new implementation deserves a new PR. We should preserve this old approach here.

cafaxo commented 3 years ago

By the way: It is not good practice to push onto another one's branch like this. In Git, everyone works on a particular branch and then asks (using a PR) to merge this branch into master. Merge conflicts are then resolved when the branch is merged with master... If I am locally working on my branch, I wouldn't want to resolve merge conflicts when pushing my branch to the remote. For example, it often occurs that I rebase my branch on top of master and then force-push it to remote. Such a process would have destroyed your commits here.

Here, it would have been better to create your own branch on top of my graph branch. Alternatively, you can use github's review system to place code suggestions in a PR, which I then could apply to my branch.

gaioguy commented 3 years ago

Apologies - and thanks for explaining the workflow. Shall I remove my commit?

cafaxo commented 3 years ago

Not necessary since I am no longer working on that branch.