Closed cafaxo closed 3 years ago
Awesome. I am going to put in some detailed comments.
Is this one ready for merging?
This PR depends on #34, so we should merge that one first. (We can merge #34 once someone takes quick look at it and approves it.)
Other than that, the main thing that is missing here is some tests. I'd also be ok with quick comparison with the output of MATLAB's GAIO. Just to check that nothing major is wrong with this implementation :)
On another note: I'm sorry for being so inactive here (master's thesis has been keeping me busy). In about a month, I'll hopefully have the time to work on this project again.
I tested this against MATLAB's GAIO with the logistic map and the Lorenz system - it gives the same eigenvalues and vectors up to 1e-12 accuracy. I guess this can be merged.
No problem - thanks for still having an eye on this.
Initial implementation of https://github.com/gaioguys/GAIO.jl/pull/32#issuecomment-663098767. This PR is in a very early stage. (I'll add a TODO list later here.)
The code
produces the following output:![lmspiky2](https://user-images.githubusercontent.com/1753343/89410999-f7898200-d724-11ea-94b6-8991a6e78683.png)