search

gaiterjones / magento-buy-x-get-y-free

Magento Buy X Get Y Free Module
43 stars 21 forks source link

Translation #1

Open uncenteredDiv opened 11 years ago

uncenteredDiv commented 11 years ago

Hello,

nice extension - i'm using it on my luggage shop to give my customers a free gift if they spend more than 75€.

But i noticed that the add/delete/... messages are all in english. Is there a way to translate them to german - do you added a translate.csv or something like this? I tried to add the translation to the Mage_checkout.csv but that not worked.

Hope you can help.

gaiterjones commented 11 years ago

Hey,

Check out the app/locale/de translation csv file. Some of the phrases are translated to german but not all. Add them to this file, send me the file when you are finished and I will add it to the module.

Peter.

On 28 Mar 2013, at 15:42, Skinwalker notifications@github.com wrote:

Hello,

nice extension - i'm using it on my luggage shop to give my customers a free gift if they spend more than 75€.

But i noticed that the add/delete/... messages are all in english. Is there a way to translate them to german - do you added a translate.csv or something like this? I tried to add the translation to the Mage_checkout.csv but that not worked.

Hope you can help.

— Reply to this email directly or view it on GitHub.

uncenteredDiv commented 11 years ago

Ok .. got the file. The add/delete phrases are included, but they don't appear on the frontend ...

gaiterjones commented 11 years ago

I think you will need to add the translations yourself, look at lines 13 onward and add in the german translations. Refresh your translation cache and try again.

On 28 Mar 2013, at 16:03, Skinwalker notifications@github.com wrote:

Ok .. got the file. The add/delete phrases are included, but they don't appear on the frontend ...

— Reply to this email directly or view it on GitHub.

uncenteredDiv commented 11 years ago

Ok that works - but not on the phrase "free gift" ... i can't translate this.

I allways get "Ihr free gift wurde dem Warenkorb hinzugefügt".

I tried "free","kostenlos" "gift","Geschenk" "free gift","Geschenk"

gaiterjones commented 11 years ago

Ok. I have to check that. The "descriptor" for the free gift, can also be set in the config, the default is "free gift" but you can set it to whatever you want in the config, and also under the store view, so you can configure Geschenk under your german or default store view, and free gift under the engilsh view (if you have one)

Peter. On 28 Mar 2013, at 16:13, Peter Jones paj@p-a-j.co.uk wrote:

I think you will need to add the translations yourself, look at lines 13 onward and add in the german translations. Refresh your translation cache and try again.

On 28 Mar 2013, at 16:03, Skinwalker notifications@github.com wrote:

Ok .. got the file. The add/delete phrases are included, but they don't appear on the frontend ...

— Reply to this email directly or view it on GitHub.

uncenteredDiv commented 11 years ago

Hey,

where in the config can i find the descriptor? I don't see in in Extension Settings or Spend X Get Y Free

uncenteredDiv commented 11 years ago

Ok i got it.

Found the "free gift" phrase in controllers/Frontend/Checkout/CartController.php

I only got a german StoreView so i chanced the "free gift" to "Geschenk". Now it works.

Thanks for the help.

gaiterjones commented 11 years ago

You are right, for Spend X there is no option to change the descriptor in the admin config, it is there for Buy X and Category X but not for Spend X, I will need to change that. But you found the default text in the code anyway.