search

gaiterjones / magento-buy-x-get-y-free

Magento Buy X Get Y Free Module
43 stars 21 forks source link

Coupon X get Y free - multiple coupons #3

Open rob3000 opened 10 years ago

rob3000 commented 10 years ago

I have found an issue when you have multiple coupon codes separated by a comma only the first coupon gets used.

On line 297 of the controller your only passing the first item and line 604 will need to be modified to check an array.

gaiterjones commented 10 years ago

Yes, I think although in admin it says you can comma seperate them I never got round to doing it...

Sent from my iPad

On 26 Nov 2013, at 03:37, rob3000 notifications@github.com wrote:

I have found an issue when you have multiple coupon codes separated by a comma only the first coupon gets used.

On line 297 of the controller your only passing the first item and line 604 will need to be modified to check an array.

— Reply to this email directly or view it on GitHub.

rob3000 commented 10 years ago

Just added a branch to update this. 1df41058e7ad4c9917f6909c0740350773f90aee

gaiterjones commented 9 years ago

Actually need to develop this further, as the coupon should actually match the y product, so with more coupons and multiple offers this logic wouldn't work.