gajus / create-index

Creates ES6 ./index.js file in target directories that imports and exports all sibling files and directories.
Other
278 stars 87 forks source link

Feat(#31): Add ignore option #37

Closed hinok closed 7 years ago

hinok commented 7 years ago
gajus commented 7 years ago

Thank you for the PR.

This lack documentation, README.md changes.

hinok commented 7 years ago

Sorry for so many changes. I applied all requested changes and removed "swallowing errors" from tests. I added also section about ignore in README.md.

gajus commented 7 years ago

Is this ready to be merged?

hinok commented 7 years ago

I thought that writeIndexCli.js uses writeIndex.js, it doesn't - my fault, I didn't check it before but it's fixed already.

I also checked this PR on my local project where I use create-index heavily to maintain icons, it works 💃

Please feel free to correct any english language issues. I think that it's ready to be merged.

gajus commented 7 years ago

Thank you