Fetching bundle name from stats & Custom context on eval

gajus / isomorphic-webpack

Abstracts universal consumption of application code base using webpack.

Other

291 stars 17 forks source link

Fetching bundle name from stats & Custom context on eval #31

Closed cryptiklemur closed 7 years ago

cryptiklemur commented 7 years ago

Fixes #18

However, idk if this is too "hardcoded"... Your existing code only allows for a single entry point, this would just get the first file of the first entry point.

coveralls commented 7 years ago

Coverage remained the same at 90.698% when pulling a28b8ef4c4f0a7ad849dc4168fdaad4241481967 on aequasi:patch-1 into 50e8896e79023314adcb1471a48319bd842ee55b on gajus:master.

cryptiklemur commented 7 years ago

Damn, i thought i was on another branch. I also added something to allow passing custom context to evalBundleCode. Handy for the new react-router: https://reacttraining.com/react-router/web/guides/server-rendering/putting-it-all-together

coveralls commented 7 years ago

Coverage remained the same at 90.698% when pulling 3f233f4b0a4096327c0c633c9891c4d9b1d6ada0 on aequasi:patch-1 into 50e8896e79023314adcb1471a48319bd842ee55b on gajus:master.

coveralls commented 7 years ago

Coverage remained the same at 90.698% when pulling 404a2aaeb04a31967f4aadec32910acfd1c1a16c on aequasi:patch-1 into 50e8896e79023314adcb1471a48319bd842ee55b on gajus:master.

coveralls commented 7 years ago

Coverage remained the same at 90.698% when pulling 404a2aaeb04a31967f4aadec32910acfd1c1a16c on aequasi:patch-1 into 50e8896e79023314adcb1471a48319bd842ee55b on gajus:master.

coveralls commented 7 years ago

Coverage remained the same at 90.698% when pulling 404a2aaeb04a31967f4aadec32910acfd1c1a16c on aequasi:patch-1 into 50e8896e79023314adcb1471a48319bd842ee55b on gajus:master.

coveralls commented 7 years ago

Coverage remained the same at 90.698% when pulling 68481c26f1572a9e1a993f7c569a07348ac53db1 on aequasi:patch-1 into 50e8896e79023314adcb1471a48319bd842ee55b on gajus:master.

coveralls commented 7 years ago

Coverage remained the same at 90.698% when pulling 68481c26f1572a9e1a993f7c569a07348ac53db1 on aequasi:patch-1 into 50e8896e79023314adcb1471a48319bd842ee55b on gajus:master.

coveralls commented 7 years ago

Coverage remained the same at 90.698% when pulling 68481c26f1572a9e1a993f7c569a07348ac53db1 on aequasi:patch-1 into 50e8896e79023314adcb1471a48319bd842ee55b on gajus:master.

cryptiklemur commented 7 years ago

Man, coveralls is spammy haha. Fixed all the tests

gajus commented 7 years ago

However, idk if this is too "hardcoded"... Your existing code only allows for a single entry point, this would just get the first file of the first entry point.

Allowing just a single entry point is fine for the purpose, but it must be the last file of the first entry point. Having multiple scripts per entry point is common usage.

cryptiklemur commented 7 years ago

Ok, changed it up. Will grab the last file that ends with .js

cryptiklemur commented 7 years ago

This logic could be updated to loop through the chunks fairly easily, but idk what needs to happen after that. Does it just need to call the callback on each chunk? Can leave that for another PR

coveralls commented 7 years ago

Coverage remained the same at 90.698% when pulling e46b6bacf8199d142adc90366cf4f41d277079f5 on aequasi:patch-1 into 50e8896e79023314adcb1471a48319bd842ee55b on gajus:master.

coveralls commented 7 years ago

Coverage remained the same at 90.698% when pulling d8dcf0652f8e6af014a6b6d602eeb0edc1971e80 on aequasi:patch-1 into 50e8896e79023314adcb1471a48319bd842ee55b on gajus:master.

coveralls commented 7 years ago

Coverage remained the same at 90.698% when pulling 78f1c6fd081aa1f68d0d9ff2c5447a92a1c8de34 on aequasi:patch-1 into 50e8896e79023314adcb1471a48319bd842ee55b on gajus:master.

coveralls commented 7 years ago

Coverage remained the same at 90.698% when pulling 78f1c6fd081aa1f68d0d9ff2c5447a92a1c8de34 on aequasi:patch-1 into 50e8896e79023314adcb1471a48319bd842ee55b on gajus:master.

cryptiklemur commented 7 years ago

Any comments @gajus or requests?