search

gajus / isomorphic-webpack

Abstracts universal consumption of application code base using webpack.
Other
291 stars 17 forks source link

Add TypeScript declarations. #35

Open jaraquistain opened 6 years ago

jaraquistain commented 6 years ago

I've recently started attempting to use this library in a TypeScript app and I noticed there is no @types/isomorphic-webpack. It would be good to provide this so users do not have to write the declarations themselves

gajus commented 6 years ago

I am not familiar with TS conventions. Wouldn't this be a separate package?

jaraquistain commented 6 years ago

You would define them in a file and open a pull request with https://github.com/DefinitelyTyped/DefinitelyTyped to include it in their repository.

See here for more info: http://definitelytyped.org/guides/contributing.html

jaraquistain commented 6 years ago

The net result is that anyone who uses typescript and your library would be able to include @types/isomorphic-webpack (as is the convention) in their package.json and won't have to define them themselves in order to stop TypeScript complaining about objects from your libarary