gajus / lightship

Abstracts readiness, liveness and startup checks and graceful shutdown of Node.js services running in Kubernetes.
Other
517 stars 33 forks source link

Update README.md adding Testing Locally guides #11

Closed waldemarnt closed 5 years ago

waldemarnt commented 5 years ago

I had to look into the code to understand that the lightship was running an express app in some random port in order to expose the endpoints. I'm adding it to the README to help people in the same situation as me. Running locally helps to test the setup ex: graceful shutdowns

coveralls commented 5 years ago

Pull Request Test Coverage Report for Build 51


Totals Coverage Status
Change from base Build 49: 0.0%
Covered Lines: 68
Relevant Lines: 78

💛 - Coveralls
gajus commented 5 years ago

This was already in the documentation template.

https://github.com/gajus/lightship/commit/95509f3dd98eedf1d1e702c4ef89c099f9f87990

Looks like I forgot to generate new README.md after the latest changes.

gajus commented 5 years ago

:tada: This issue has been resolved in version 4.1.1 :tada:

The release is available on:

Your semantic-release bot :package::rocket: