search

gajus / lightship

Abstracts readiness, liveness and startup checks and graceful shutdown of Node.js services running in Kubernetes.
Other
517 stars 33 forks source link

Do not send 500 on shutdown #12

Closed florianmutter closed 5 years ago

florianmutter commented 5 years ago

According to https://freecontent.manning.com/handling-client-requests-properly-with-kubernetes/ it is not necessary to send 500 on shutdown. I think it should be avoided to have more meaning full event logs of the pods. Otherwise each shutdown generates logs of failed readiness requests

gajus commented 5 years ago

:tada: This issue has been resolved in version 4.2.0 :tada:

The release is available on:

Your semantic-release bot :package::rocket:

gajus commented 5 years ago

Added a note to the README.md referencing the article.