Fix delay module missing as dependency

gajus / lightship

Abstracts readiness, liveness and startup checks and graceful shutdown of Node.js services running in Kubernetes.

Other

517 stars 33 forks source link

Fix delay module missing as dependency #13

Closed waldemarnt closed 5 years ago

waldemarnt commented 5 years ago

When running lightship in production mode the delay module is missing. Having a look I found out that it has been imported as devDependency.

This PR moves it to the right place

Error: Cannot find module 'delay'
Require stack:
- /Users/wneto/Dev/node-docker-example/node_modules/lightship/dist/factories/createLightship.js
- /Users/wneto/Dev/node-docker-example/node_modules/lightship/dist/index.js

coveralls commented 5 years ago

Pull Request Test Coverage Report for Build 59

0 of 0 changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 86.047%

Totals
Change from base Build 57:	0.0%
Covered Lines:	85
Relevant Lines:	97

💛 - Coveralls

coveralls commented 5 years ago

Pull Request Test Coverage Report for Build 59

0 of 0 changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 86.047%

Totals
Change from base Build 57:	0.0%
Covered Lines:	85
Relevant Lines:	97

💛 - Coveralls

gajus commented 5 years ago

:tada: This PR is included in version 4.3.1 :tada:

The release is available on:

Your semantic-release bot :package::rocket: