search

gajus / lightship

Abstracts readiness, liveness and startup checks and graceful shutdown of Node.js services running in Kubernetes.
Other
517 stars 33 forks source link

Support GKE #14

Closed xfumihiro closed 5 years ago

xfumihiro commented 5 years ago

Thanks for the great lib! However due to the different port requirement, lightship isn't usable for GKE.

https://cloud.google.com/kubernetes-engine/docs/concepts/ingress#health_checks

Note that the Service exposed through an Ingress must point to the same container port on which the readiness probe is enabled.

Would you consider to make this a middleware so it can use the same port?

gajus commented 5 years ago

That is talking about load-balancer, which is unrelated to Kubernetes Controller Manager. Lightship is specifically designed for working within Kubernetes cluster, not interactive with external services.

You can simply have any HTTP service for the purposes of LB liveness check.