Would it be better to wait for the server close event instead of a fixed time?

[zhaoyao91]

In the README, I noticed it suggest wait some time before calling server.close(). According to the node.js doc, could the following code snippet be better? Or is there some other consideration?

lightship.registerShutdownHandler(() => {
  return new Promise((resolve, reject) => {
    server.close(err => {
      if (err) reject(err);
      else resolve();
    });
  });
});

[gajus]

Don't do that – you will kill active requests.

See:

• https://github.com/gajus/lightship#add-a-delay-before-stop-handling-incoming-requests
• https://freecontent.manning.com/handling-client-requests-properly-with-kubernetes/

[gajus]

Sorry, you won't kill active requests in this case. However, it is possible that the server might still receive requests after receiving the SIGKILL, i.e. you need to allow time to ensure that no more traffic is being routed to your pod instance.

See:

• https://freecontent.manning.com/handling-client-requests-properly-with-kubernetes/

[zhaoyao91]

Seems that the delay is a magic number since we don't know how many time it will take to switch iptables.

[gajus]

That is correct.