gajus / lightship

Abstracts readiness, liveness and startup checks and graceful shutdown of Node.js services running in Kubernetes.
Other
518 stars 32 forks source link

Should business server handle gracefully shutdown? #27

Closed finian closed 3 years ago

finian commented 3 years ago

The gracefully shutdown is applied to the new created express app (server): https://github.com/gajus/lightship/blob/5cd9373098e3cb74c7049c14667d8de99494e004/src/factories/createLightship.js#L74-L80

What about the business one? Should we handle it manually (with createHttpTerminator)?

gajus commented 3 years ago

Should we handle it manually (with createHttpTerminator)?

Yes