search

gajus / lightship

Abstracts readiness, liveness and startup checks and graceful shutdown of Node.js services running in Kubernetes.
Other
518 stars 32 forks source link

Prefix or custom urls for endpoints #28

Closed giedrius-timinskis closed 3 years ago

giedrius-timinskis commented 3 years ago

Hello

I have a requirement to put all healthcheck endpoints behind a /internal prefix.

What are your opinions on allowing users to either customise the endpoints, or supply a prefix?

I am happy to create a PR with proposed changes, but I thought you might have had specific reasons for not allowing custom endpoints. If you do, I'd be curious to hear them.

Thanks!

gajus commented 3 years ago

I am happy to create a PR with proposed changes, but I thought you might have had specific reasons for not allowing custom endpoints. If you do, I'd be curious to hear them.

Health checks are under a custom, dedicated port, that should never be exposed to public. Therefore, there is no need for a special prefix.