search

gajus / lightship

Abstracts readiness, liveness and startup checks and graceful shutdown of Node.js services running in Kubernetes.
Other
518 stars 32 forks source link

lightship module has been broken since yesterday #36

Closed yocontra closed 3 years ago

yocontra commented 3 years ago

Was getting the MODULE_NOT_FOUND issue reported previously, and on the latest version getting this now:

import { createLightship } from 'lightship'
         ^^^^^^^^^^^^^^^
SyntaxError: Named export 'createLightship' not found. The requested module 'lightship' is a CommonJS module, which may not support all module.exports as named exports.
CommonJS modules can always be imported via the default export, for example using:

import pkg from 'lightship';
const { createLightship } = pkg;

    at ModuleJob._instantiate (node:internal/modules/esm/module_job:105:21)
    at async ModuleJob.run (node:internal/modules/esm/module_job:151:5)
    at async Loader.import (node:internal/modules/esm/loader:166:24)
    at async Object.loadESM (node:internal/process/esm_loader:68:5)

Looking at the changelog I think 6.6.2 is when it entered this broken state, reverting to 6.6.1 is a fine workaround for now.

6.6.2+ also added about 1000 lines of new dependencies in lockfiles across our services.

gajus commented 3 years ago

I cannot replicate this as an issue.