search

gajus / lightship

Abstracts readiness, liveness and startup checks and graceful shutdown of Node.js services running in Kubernetes.
Other
518 stars 32 forks source link

Expose state logging #37

Closed alexandervantrijffel closed 3 years ago

alexandervantrijffel commented 3 years ago

First of all, thanks for sharing this excellent package for application lifecycle management and serving endpoints for Kubernetes health probes.

We at Grandvision are investigating whether we can adopt Lightship. What is holding us back is that there is no possibility to inject our logging infrastructure based on Winston. And the information being logged by lightship is very useful for debugging and analysis. Can you consider to either support other loggers or introduce callbacks or events to inform consumers of the package about state changes?

gajus commented 3 years ago

If you really wanted to, you could always just override ROARR.write method.

import {
  ROARR,
} from 'roarr';

ROARR.write = () => {};

No plans of supporting other loggers. Motivation explained here.

alexandervantrijffel commented 3 years ago

Thanks @gajus, that works for us.