gajus / lightship

Abstracts readiness, liveness and startup checks and graceful shutdown of Node.js services running in Kubernetes.
Other
515 stars 33 forks source link

Seeming Grace Period Shutdown Default Mismatch #38

Closed MissingHandle closed 1 year ago

MissingHandle commented 2 years ago

per this documentation:

https://v1-18.docs.kubernetes.io/docs/reference/generated/kubernetes-api/v1.18/

terminationGracePeriodSeconds defaults to 30 seconds.

but per the lightship readme, the default grace period is 60 seconds.

so the default lightship config seems misleading relative to the default k8s config.

gajus commented 1 year ago

:tada: This issue has been resolved in version 7.0.4 :tada:

The release is available on:

Your semantic-release bot :package::rocket: