search

gajus / lightship

Abstracts readiness, liveness and startup checks and graceful shutdown of Node.js services running in Kubernetes.
Other
518 stars 32 forks source link

:bookmark: ES6 support #46

Closed jaspermayone closed 2 years ago

jaspermayone commented 2 years ago

Closes and solves #45.

I think?

coveralls commented 2 years ago

Pull Request Test Coverage Report for Build 160

Files with Coverage Reduction New Missed Lines %
src/utilities/isKubernetes.ts 1 0%
src/states.ts 6 0%
src/factories/createLightship.ts 116 0%
<!-- Total: 123 -->
Totals Coverage Status
Change from base Build 158: -88.2%
Covered Lines: 0
Relevant Lines: 135
💛 - Coveralls
gajus commented 2 years ago

Module support will get shipped when TypeScript supports it natively.

jaspermayone commented 2 years ago

This is a pain in the but for everyone who wants to use this package now with the ES6 syntax.

Does this PR not solve that temporarily?