feat: Update `fastify` to expose API for `HEAD` requests.

gajus / lightship

Abstracts readiness, liveness and startup checks and graceful shutdown of Node.js services running in Kubernetes.

Other

518 stars 32 forks source link

feat: Update `fastify` to expose API for `HEAD` requests. #47

Closed hsubra89 closed 1 year ago

hsubra89 commented 2 years ago

This patch enables a fastify config to enable HEAD requests. Readiness and liveness checks should respond correctly to HEAD requests since only the status codes are usually relevant for checking the status of services via tools like curl.

Eg:

https://hub.docker.com/r/stefanevinance/wait-for-200/ https://github.com/stefan-evinance/wait-for-200

Tests have been updated to verify this behaviour.

coveralls commented 2 years ago

Pull Request Test Coverage Report for Build 169

1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 88.35%

Totals
Change from base Build 168:	0.0%
Covered Lines:	140
Relevant Lines:	152

💛 - Coveralls

hsubra89 commented 2 years ago

@gajus This is currently blocking me from using the latest version of lightship. If merged, could you consider releasing a minor or patch revision?

hsubra89 commented 2 years ago

@gajus Any update on this please?

gajus commented 1 year ago

Sometimes notifications get lost :-(

Looking at this now

gajus commented 1 year ago

:tada: This issue has been resolved in version 7.1.0 :tada:

The release is available on:

Your semantic-release bot :package::rocket: